-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: properly handle visible whitespaces in empty blocks #2865
Open
idebenone
wants to merge
9
commits into
next
Choose a base branch
from
fix/whitespace-input-placeholder
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idebenone
requested review from
neSpecc,
gohabereg,
TatianaFomina and
ilyamore88
as code owners
November 9, 2024 10:22
idebenone
force-pushed
the
fix/whitespace-input-placeholder
branch
from
November 9, 2024 10:46
363612c
to
af3540a
Compare
neSpecc
reviewed
Nov 9, 2024
…ix/whitespace-input-placeholder
idebenone
force-pushed
the
fix/whitespace-input-placeholder
branch
from
November 18, 2024 19:08
c2ab46f
to
fb311d0
Compare
neSpecc
approved these changes
Nov 19, 2024
idebenone
force-pushed
the
fix/whitespace-input-placeholder
branch
from
November 19, 2024 19:41
096dd66
to
b9e8404
Compare
neSpecc
requested changes
Nov 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, we should add tests for these 2 cases
- backspace should remove trailing whitespaces in empty blocks
- whitespaces in empty block should hide the placeholder
neSpecc
reviewed
Nov 24, 2024
neSpecc
approved these changes
Nov 25, 2024
idebenone
force-pushed
the
fix/whitespace-input-placeholder
branch
from
November 25, 2024 17:50
cb7a9e4
to
057914c
Compare
neSpecc
requested changes
Nov 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Be aware, don't delete submodules from the repo
e11sy
approved these changes
Nov 28, 2024
idebenone
changed the title
Fix caret moving to end of placeholder on whitespace input
fix: properly handle visible whitespaces in empty blocks
Nov 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Improper handling of visible whitespaces causing unwanted behaviour such as:
paragraph
block.Solution
Update the
isNodeEmpty()
to handle visible whitespaces by removing the method calltrim()
innodeText.trim().length
as it would remove the trailing whitespaces if any exist which in turn falsely marks a block as empty. And because of this the whitespaces are unable to be removed.