Further improvements for hotspots element #2156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not toggle back to previous emulation mode when leaving edit area view. Keep preview stable when returning to area list or selecting sibling content element. Restore selected area to help Firefox that loses track of scroller position when preview dimensions change. REDMINE-20673
Selecting the section after a pan-zoom hotspot had been selected, caused the pan-zoom animation to stay stuck in Firefox instead of reverting to the initial step. The `mousedown` on the section triggers both the selection change and the `onDismiss` callback of the floating tooltip that is supposed to scroll the hotspots scroller back to the first position. When the section is selected, we toggle a `selected` CSS class on the section to display a selection rect made of pseudo elements. Toggling these pseudo elements causes a reflow that makes Firefox drop the `scroll` event that would have been triggered by scrolling the hotspots scroller. The scroll timeline polyfill then has no opportunity to refresh the position of the hotspots image causing it to stay stuck. REDMINE-20673
REDMINE-20673
REDMINE-20673
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REDMINE-20673