Fix drag image of dragged section in Safari #2154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Safari apparently get confused with the scaled section thumbnail and incorrectly uses a much larger rectangle when generating the drag image of a dragged section item. The image then also includes text of other chapters and section items of the outline and parts of the sidebar footer. Use fallback instead of native draggable for sections in Safari. Related: SortableJS/Sortable#291 REDMINE-20837
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Safari apparently gets confused with the scaled section thumbnail and incorrectly uses a much larger rectangle when generating the drag image of a dragged section item. The image then also includes text of other chapters and section items of the outline and parts of the sidebar footer.
Use fallback instead of native draggable for sections in Safari.
Related: SortableJS/Sortable#291
REDMINE-20837