Backdrop content elements #2093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tf
force-pushed
the
backdrop-content-elements
branch
3 times, most recently
from
c5991c8 to
32ff508
Compare
REDMINE-20634
REDMINE-20634
REDMINE-20634
* Setting position to `backdrop` changes backdrop type to `contentElement`. * There can only ever be one backdrop content element in a section. * Changing backdrop type from `contentElement` resets position of backdrop content element to inline. * Toggling backdrop type back to `contentElement` restores position of previous backdrop content element. * Changing position from `backdrop` restores previous backdrop type. REDMINE-20634
Allow scrolling to same section twice in a row. REDMINE-20364
* Pad content * Do not apply dynamic shadow when section is empty * Apply different section heights based on section transitions REDMINE-20636
Turn `useSectionContentElements` hook into `useSectionForegroundcontentelements` hook which filters out elements with position `backdrop`. Introduce `useContentElement` hook to look up elements by perma id and use it to render content element in the backdrop if `section.backdrop.contentElement` is set. At the moment, perma ids might get re-used once an element is deleted and another one is created. We need to prevent the new element from being treated as the backdrop of the section if it belongs to another section. We therefore check the sectionId of the element. REDMINE-20634
REDMINE-20634
Allow filling viewport with content. REDMINE-20634
REDMINE-20634
REDMINE-20634
Confusing now that some inline elements can also be used as backdrops. REDMINE-20634
Rename "transparent" to "fadedOut". REDMINE-20634
REDMINE-20634
…elected REDMIN-20634
REDMINE-20634
tf
force-pushed
the
backdrop-content-elements
branch
2 times, most recently
from
001cb76 to
27d8a90
Compare
Ensure player controls are already in the viewport even when the video has not been scrolled fully into the viewport. REDMINE-20634
Position backdrop from bottom to ensure controls of backdrop videoe elements are moved up when mobile Safari expands its location bar at the bottom or stay in place when Chrome on Android expands its location bar at the top. REDMINE-20634
tf
force-pushed
the
backdrop-content-elements
branch
from
27d8a90 to
e274308
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REDMINE-20634