Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix scrolled specs for Rails 6 #2003

Merged
merged 5 commits into from
Sep 18, 2023
Merged

Fix scrolled specs for Rails 6 #2003

merged 5 commits into from
Sep 18, 2023

Conversation

tf
Copy link
Member

@tf tf commented Sep 18, 2023

REDMINE-19438

tf added 5 commits September 18, 2023 10:58
@tf
Fix keyword arguments for Ruby 3
f4083a8 
REDMINE-19438
@tf
Pass entry type param in editor controller specs
e05162b 
Required to find matching route. Also closer to real request. Entry
type of fixture entry needs to match passed entry type to prevent
`Pageflow::EditorController` from responding with bad reqest.

REDMINE-19438
@tf
Make file fixtures work in Rails 6
c22ad25 
REDMINE-19438
@tf
Use Shakapacker instead of Webpacker with Rails 6
2e2e095 
REDMINE-19438
@tf
Run Pageflow Scrolled specs against rails 6
b994fb7 
REDMINE-19438
@tf tf added this to the v16.1.0 milestone Sep 18, 2023
@tf tf merged commit f42e681 into codevise:master Sep 18, 2023
14 checks passed
@tf tf deleted the rails-6-entry-types branch September 18, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hound hound[bot] hound[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v16.1
Development

Successfully merging this pull request may close these issues.
1 participant
@tf