-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logical/math operators to fix #739 #761
Conversation
I didn't use docker to build the project, nor am I supper familiar with it. How should I best go about fixing the code to pass that test case? |
One of the reasons it's not a required check is that occasionally the build of that fails due to a library that sometimes breaks when the build happens. Nothing has changed with Docker, so that's fine. I've merged other PRs despite that failing. |
"code": "a >= b" | ||
}, | ||
"null_coalescing": { | ||
"name": "Elvis operator", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name doesn't technically show up, it's pulled in from the meta file. It'll still show up as a null-coalescing operator. You might want to clarify in the comment that's the case here (and also Kotlin calls it that)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can merge this in but don't know if you want to change the Elvis operator comment first. Let me know!
I changed the name to null coalescing and instead mentioned in the comment that it is also known as the Elvis operator |
You could have left it in there, just the name field is mostly for convenience of making the file here, not actually used. |
You did, I didn't finish looking. But thakn you for contributing! I'll merge it in. Happy Hacktoberfest! |
What GitHub issue does this PR apply to?
Resolves #739
What changed and why?
I've added the full set of arithmetic, logical, and bit-wise operators for the Kotlin language.
Checklist
Any additional comments or things to be aware of while reviewing?
Kotlin docs were the primary source and instrumental in resolving this issue.