Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logical/math operators to fix #739 #761

Merged
merged 3 commits into from
Oct 31, 2024
Merged

Conversation

Add00
Copy link

@Add00 Add00 commented Oct 29, 2024

What GitHub issue does this PR apply to?

Resolves #739

What changed and why?

I've added the full set of arithmetic, logical, and bit-wise operators for the Kotlin language.

Checklist

  • I claimed any associated issue(s) and they are not someone else's
  • I have looked at documentation to ensure I made any revisions correctly
  • I tested my changes locally to ensure they work
  • For language files, I have validated the edited files are valid JSON and data shows up correctly
  • For website code edits, I have added or edited any appropriate unit tests for my changes

Any additional comments or things to be aware of while reviewing?

Kotlin docs were the primary source and instrumental in resolving this issue.

@Add00
Copy link
Author

Add00 commented Oct 29, 2024

I didn't use docker to build the project, nor am I supper familiar with it. How should I best go about fixing the code to pass that test case?

@geekygirlsarah
Copy link
Member

I didn't use docker to build the project, nor am I supper familiar with it. How should I best go about fixing the code to pass that test case?

One of the reasons it's not a required check is that occasionally the build of that fails due to a library that sometimes breaks when the build happens. Nothing has changed with Docker, so that's fine. I've merged other PRs despite that failing.

"code": "a >= b"
},
"null_coalescing": {
"name": "Elvis operator",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name doesn't technically show up, it's pulled in from the meta file. It'll still show up as a null-coalescing operator. You might want to clarify in the comment that's the case here (and also Kotlin calls it that)

Copy link
Member

@geekygirlsarah geekygirlsarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can merge this in but don't know if you want to change the Elvis operator comment first. Let me know!

@Add00
Copy link
Author

Add00 commented Oct 31, 2024

I changed the name to null coalescing and instead mentioned in the comment that it is also known as the Elvis operator

@geekygirlsarah
Copy link
Member

You could have left it in there, just the name field is mostly for convenience of making the file here, not actually used.

@geekygirlsarah
Copy link
Member

You did, I didn't finish looking.

But thakn you for contributing! I'll merge it in.

Happy Hacktoberfest!

@geekygirlsarah geekygirlsarah merged commit 9908469 into codethesaurus:main Oct 31, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Kotlin] Add logical/math operators
2 participants