-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kotlin String Implementaiton #759
Conversation
From the validating checks:
I think I also saw a (The docker check is an issue related to a library it uses, and isn't a fault of this PR so I'm ignoring it) |
My bad !!!! Fixed it. |
Those still need to be fixed, they failed the validating check again. |
@geekygirlsarah Are there any instructions on how to run the tests? |
I swore we had a docs page on it, but I'm not seeing it. Either I'm tired or it doesn't exist! 😆 you can run: Ideally run both to get a full check on it. |
Clearly I thought this through a year ago! 😆 |
@geekygirlsarah Added some testing docs as well for the contribution page. All test cases are passing now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see the tests pass, so that helps! I'll merge this in with the README adjustments!
Ignoring the Docker build issue, this is good to go! I'll merge it in. Happy Hacktoberfest! This counts towards that if you're participating! |
What GitHub issue does this PR apply to?
Resolves #741
What changed and why?
Implemented changes for Kotlin String.
(If editing website code) Please add screenshots
Checklist
Any additional comments or things to be aware of while reviewing?