Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update strings.json #754

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Conversation

sarthakjalan05
Copy link
Contributor

@sarthakjalan05 sarthakjalan05 commented Oct 6, 2024

What GitHub issue does this PR apply to?

Resolves #717

What changed and why?

Added more detailed options under the String Formatting section to include signed/unsigned integer formatting and floating-point formatting.
Renamed the basic format operations to be more specific to how C works.

(If editing website code) Please add screenshots

Checklist

  • I claimed any associated issue(s) and they are not someone else's
  • I have looked at documentation to ensure I made any revisions correctly
  • I tested my changes locally to ensure they work
  • For language files, I have validated the edited files are valid JSON and data shows up correctly
  • For website code edits, I have added or edited any appropriate unit tests for my changes

Any additional comments or things to be aware of while reviewing?

@geekygirlsarah geekygirlsarah temporarily deployed to codethesaurus-test-pr-754 October 7, 2024 22:59 Inactive
Copy link
Member

@geekygirlsarah geekygirlsarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good, and good catch on the typos. Thanks!

Be sure to sign up for Hacktoberfest if you haven't, this PR counts towards it!

@geekygirlsarah geekygirlsarah merged commit 0130d2d into codethesaurus:main Oct 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ambiguous number formatting within strings meta language file
2 participants