Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kotlin Language Support for Classes Structure (#728) #729

Merged
merged 2 commits into from
Jul 22, 2024
Merged

Add Kotlin Language Support for Classes Structure (#728) #729

merged 2 commits into from
Jul 22, 2024

Conversation

naeem4633
Copy link
Contributor

@naeem4633 naeem4633 commented Jul 20, 2024

Changes done to meta_info.json

  • Added Kotlin folder.

What GitHub issue does this PR apply to?

Resolves #728

What changed and why?

  • Added a new folder named kotlin inside the web/thesauruses directory.
  • Created a subfolder 1.5 within the kotlin directory to represent Kotlin version 1.5.
  • Added a classes.json file inside the kotlin/1.5 directory containing the necessary content to define various class concepts in Kotlin.
  • Updated the meta_info.json file to include an entry for Kotlin and to ensure that the "Classes" structure is recognized for Kotlin.

(If editing website code) Please add screenshots

  • Not applicable.

Checklist

  • I claimed any associated issue(s) and they are not someone else's
  • I have looked at documentation to ensure I made any revisions correctly
  • I tested my changes locally to ensure they work
  • For language files, I have validated the edited files are valid JSON and data shows up correctly
  • For website code edits, I have added or edited any appropriate unit tests for my changes

Any additional comments or things to be aware of while reviewing?

  • None.

Changes done to meta_info.json.
added Kotlin folder
Copy link
Member

@geekygirlsarah geekygirlsarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know about the comments, and I can approve if you don't think it should be fixed

web/thesauruses/kotlin/1.5/classes.json Outdated Show resolved Hide resolved
web/thesauruses/kotlin/1.5/classes.json Outdated Show resolved Hide resolved
Copy link
Member

@geekygirlsarah geekygirlsarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. I'll merge it in. Thank you for adding Kotlin to the site!

@geekygirlsarah geekygirlsarah merged commit 1e4ec1a into codethesaurus:main Jul 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal to Add Kotlin "Classes" Concept
2 participants