Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed error for comments with a list #709

Merged
merged 3 commits into from
Nov 28, 2023

Conversation

ulyssear
Copy link
Contributor

@ulyssear ulyssear commented Nov 5, 2023

What GitHub issue does this PR apply to?

Resolves #700
Resolves #712

What changed and why?

Joins elements with a new line feed character in comments if it's an instance of list.

(If editing Django app) Please add screenshots

Checklist

  • I claimed any associated issue(s) and they are not someone else's
  • I have looked at documentation to ensure I made any revisions correctly
  • I tested my changes locally to ensure they work
  • (If editing Django) I have added or edited any appropriate unit tests for my changes

Any additional comments or things to be aware of while reviewing?

No.

Copy link
Member

@geekygirlsarah geekygirlsarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this would probably be the problem. Thanks for fixing it so quickly (despite my not-quick approving)! I appreciate it.

@geekygirlsarah geekygirlsarah merged commit 26c9a66 into codethesaurus:main Nov 28, 2023
5 checks passed
@ulyssear ulyssear deleted the bugfixes/700 branch November 29, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants