Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added message at top of page if thesaurus is incomplete #706

Merged
merged 3 commits into from
Nov 28, 2023

Conversation

ulyssear
Copy link
Contributor

@ulyssear ulyssear commented Nov 5, 2023

What GitHub issue does this PR apply to?

New PR for #636 and #665
Resolves #635

What changed and why?

Adds message at top of page if a thesaurus is incomplete.

(If editing Django app) Please add screenshots

image

Checklist

  • I claimed any associated issue(s) and they are not someone else's
  • I have looked at documentation to ensure I made any revisions correctly
  • I tested my changes locally to ensure they work
  • (If editing Django) I have added or edited any appropriate unit tests for my changes

Any additional comments or things to be aware of while reviewing?

@geekygirlsarah
Copy link
Member

geekygirlsarah commented Nov 28, 2023

This PR is fine, but it's missing the command that was written in #636. Were you going to add that back in?

Never mind, you did #708 for that. I'll merge this in!

@geekygirlsarah geekygirlsarah merged commit c46c2db into codethesaurus:main Nov 28, 2023
5 checks passed
@ulyssear ulyssear deleted the features/draft-fixed branch November 29, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update generate_template function and add UI for incomplete file
2 participants