Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added powershell as new langage with classes as first concept #696

Merged

Conversation

ulyssear
Copy link
Contributor

@ulyssear ulyssear commented Oct 29, 2023

What GitHub issue does this PR apply to?

Resolves #449
Resolves #695

What changed and why?

Powershell was missing in the available languages.

(If editing Django app) Please add screenshots

No screenshot is necessary.

Checklist

  • I claimed any associated issue(s) and they are not someone else's
  • I have looked at documentation to ensure I made any revisions correctly
  • I tested my changes locally to ensure they work
  • (If editing Django) I have added or edited any appropriate unit tests for my changes

Any additional comments or things to be aware of while reviewing?

No.

Copy link
Member

@geekygirlsarah geekygirlsarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have one question, but then it's good to merge.

web/thesauruses/powershell/7/classes.json Outdated Show resolved Hide resolved
@ulyssear ulyssear mentioned this pull request Oct 29, 2023
@ulyssear
Copy link
Contributor Author

ulyssear commented Oct 30, 2023

I know it's a bit late for this, is it possible to have the "hacktoberfest-accepted" label ?

Copy link
Member

@geekygirlsarah geekygirlsarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change. I'll merge it in.

@geekygirlsarah geekygirlsarah merged commit 8198a94 into codethesaurus:main Oct 30, 2023
4 checks passed
@ulyssear ulyssear deleted the features/powershell-classes branch October 30, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Powershell] Add classes [PowerShell] Add PowerShell Core support
2 participants