Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github action to test docker container build #693

Conversation

ulyssear
Copy link
Contributor

What GitHub issue does this PR apply to?

Resolves #677

What changed and why?

A github action has been created which checks docker container build.

(If editing Django app) Please add screenshots

Checklist

  • I claimed any associated issue(s) and they are not someone else's
  • I have looked at documentation to ensure I made any revisions correctly
  • I tested my changes locally to ensure they work
  • (If editing Django) I have added or edited any appropriate unit tests for my changes

Any additional comments or things to be aware of while reviewing?

I know I didn't claim this pull request before. I hope this can be merged.

Now on pull request only
@Anurag-Nagpal
Copy link

Hey @ulyssear, I had also tried this but my github-action always failed:-
https://github.com/Anurag-Nagpal/codethesaur.us/actions/runs/6669393621/job/18127070143

I see your github-action is also failing with the same error, downloading requirements.txt in docker(specifically package psycopg2-binary-2.9.5).

 Error: pg_config executable not found.

I am curious how you will handle this error to pass the github-action, I am now able to figure out how to resolve this.
cc: @geekygirlsarah

my changes for reference only: https://github.com/Anurag-Nagpal/codethesaur.us/blob/main/.github/workflows/docker-build-test.yml

@ulyssear
Copy link
Contributor Author

Hello ! I resolved the issue in this pull request : #665 (comment)

Copy link
Member

@geekygirlsarah geekygirlsarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll tentatively approve this but won't merge until the other PR that changes Dockerfile is merged, and we retest this. Thanks!

@ulyssear
Copy link
Contributor Author

I removed Dockerfile of the indexed files in PR #665

Copy link
Member

@geekygirlsarah geekygirlsarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test works but fails because the Docker container needs an update, so I can merge this in (and we hopefully fix this soon).

Thank you!

@geekygirlsarah geekygirlsarah merged commit 190a392 into codethesaurus:main Oct 30, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add GitHub Action to test the build of Docker containers
3 participants