-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Github action to test docker container build #693
Github action to test docker container build #693
Conversation
Now on pull request only
0b7f25d
to
5c31037
Compare
Hey @ulyssear, I had also tried this but my github-action always failed:- I see your github-action is also failing with the same error, downloading requirements.txt in docker(specifically package psycopg2-binary-2.9.5).
I am curious how you will handle this error to pass the github-action, I am now able to figure out how to resolve this. my changes for reference only: https://github.com/Anurag-Nagpal/codethesaur.us/blob/main/.github/workflows/docker-build-test.yml |
Hello ! I resolved the issue in this pull request : #665 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll tentatively approve this but won't merge until the other PR that changes Dockerfile is merged, and we retest this. Thanks!
I removed Dockerfile of the indexed files in PR #665 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test works but fails because the Docker container needs an update, so I can merge this in (and we hopefully fix this soon).
Thank you!
What GitHub issue does this PR apply to?
Resolves #677
What changed and why?
A github action has been created which checks docker container build.
(If editing Django app) Please add screenshots
Checklist
Any additional comments or things to be aware of while reviewing?
I know I didn't claim this pull request before. I hope this can be merged.