Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 679 add language basics #688

Conversation

sayantandasgupta
Copy link
Contributor

@sayantandasgupta sayantandasgupta commented Oct 12, 2023

What GitHub issue does this PR apply to?

Resolves #679

What changed and why?

Added the basic details regarding the structure or features of any programming language including features like

  • Type Systems
  • Paradigm Category
  • Level of Abstraction
  • Execution Domain
  • Application Domain
  • Memory Management

(If editing Django app) Please add screenshots

Checklist

  • I claimed any associated issue(s) and they are not someone else's
  • I have looked at documentation to ensure I made any revisions correctly
  • I tested my changes locally to ensure they work
  • (If editing Django) I have added or edited any appropriate unit tests for my changes

Any additional comments or things to be aware of while reviewing?

@geekygirlsarah
Copy link
Member

The Validate Meta Info File failed because:

web/thesauruses/_meta/language_basics.json is not listed as a structure in meta_info.json
If you add language basics to web/thesauruses/meta_info.json, that should pass.

@sayantandasgupta
Copy link
Contributor Author

Oh. Shoot! I must have missed it. So sorry about that. Am fixing it right away

Copy link
Member

@geekygirlsarah geekygirlsarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine, but I mention a few things in #679 that I think you could add on here too. Could you add those please?

@geekygirlsarah geekygirlsarah temporarily deployed to codethesaurus-test-pr-688 October 16, 2023 23:21 Inactive
@sayantandasgupta
Copy link
Contributor Author

Of course. I was prepared for any additional features it may require. I will work on those right away

@sayantandasgupta
Copy link
Contributor Author

@geekygirlsarah I have added the following features

  • Entry Point of a Language
  • How to add comments
  • Library and Framework Support
  • Minimal Program to write

Copy link
Member

@geekygirlsarah geekygirlsarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a pretty good start I think! I might tweak it a bit on my own. It's good enough to merge, I think.

Thank you for adding this! Happy Hacktoberfest!

@geekygirlsarah geekygirlsarah merged commit e3d138d into codethesaurus:main Oct 29, 2023
4 checks passed
@sayantandasgupta
Copy link
Contributor Author

Thank You for helping me out. Would like to contribute more in the future

@sayantandasgupta
Copy link
Contributor Author

Just one tiny thing. My PR is showing as Not Accepted on Hacktoberfest website. I don't know why @geekygirlsarah

@geekygirlsarah
Copy link
Member

They refresh the stats periodically, it's not instantaneous. Check back in a few hours. If it's still not in the waiting period, let me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Structure] Add language basics
2 participants