Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue#546 #664

Closed
wants to merge 3 commits into from
Closed

Fixes issue#546 #664

wants to merge 3 commits into from

Conversation

Neeraj8949
Copy link

@Neeraj8949 Neeraj8949 commented Mar 1, 2023

What GitHub issue does this PR apply to?

Resolves #546

What changed and why?

<!-I just added a file in which all function related with queue and stack are include and also syntax to apply them -->

(If editing Django app) Please add screenshots

Checklist

  • I claimed any associated issue(s) and they are not someone else's
  • I have looked at documentation to ensure I made any revisions correctly
  • I tested my changes locally to ensure they work
  • (If editing Django) I have added or edited any appropriate unit tests for my changes

Any additional comments or things to be aware of while reviewing?

@cafce25
Copy link
Contributor

cafce25 commented Mar 1, 2023

For reference it would really help if you add the info that you added queues and stacks to C++ under the "What changed and why?" section in my opinion. As it is currently one has to search for that info elsewhere.

@geekygirlsarah
Copy link
Member

image

Did you follow the directions when making this? The concept names have to match up with what's expected and they don't. Follow the directions here to do it correctly: https://docs.codethesaur.us/thesaurus/add-lang-concept/

You're welcome to try this again by pushing to your branch/repo again.

"language": "cpp",
"language_version": "C++17",
"language_name": "C++",
"structure": "queue and stacks"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be the name of the JSON file (so queues_stacks)

Comment on lines +9 to +70
"Inbuild_Header_file_for_queue":{
"code":"#include<queue>",
"name":"For implement queue container in our cpp file iclude this header file"
},
"Syntax_for_queue":{
"code":"queue<objectType> queue_name",
"name":"The general syntax for declaration of the queue"
},
"Push_operation_in_queue":{
"code":"queue_name.push(element)",
"name":" Function push adds the element at the end of the queue i.e. at the back of the queue"
},
"Pop_operation_in_queue":{
"code":"queue_name.pop(element)",
"name":"Function ‘pop’ removes the first element of the queue i.e. the element at the front of the queue"
},
"front_function_in_queue":{
"code":"queue_name.front()",
"name":"This function returns a reference to the first element of the queue"
},
"back_function_in_queue":{
"code":"queue_name.back()",
"name":"Back returns a reference to the last element in the queue"
},
"empty_function_in_queue":{
"code":"queue_name.empty()",
"name":"Checks if the queue is empty"
},
"size_function_in_queue":{
"code":"queue_name.size()",
"name":"Returns the size of the queue i.e. the number of elements in the queue"
},
"Inbuild_Header_file_for_stacks":{
"code":"#include<stack>",
"name":"In order to implement stack container, we need to include the header <stack> in our program"
},
"Syntax_for_stack":{
"code":"stack<objectType> stack_name",
"name":"The general syntax for declaration of the queue"
},
"Push_operation_in_stack":{
"code":"stack_name.push(element)",
"name":" push operation is used to insert an element in the stack. This operation always adds elements at the top of the stack"
},
"Pop_operation_in_stack":{
"code":"stack_name.pop(element)",
"comment":"As a result of the pop operation, the stack size is reduced by 1",
"name":"pop operation is used to remove an element from the stack. The element removed is the one that is pointed to by the top of the stack"
},
"top_function_in_stack":{
"code":"stack_name.top()",
"name":"Returns the topmost element of the stack"
},
"empty_function_in_stack":{
"code":"stack_name.empty()",
"name":" Returns the size of the stack i.e. the number of elements in the stack"
},
"size_function_in_stack":{
"code":"queue_name.size()",
"name":"Returns the size of the queue i.e. the number of elements in the queue"
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are not valid concept names. (See previous comment.)

@geekygirlsarah
Copy link
Member

I'm closing this PR has the changes haven't been made and I haven't heard from you. You are welcome to reclaim the issue and work on it some more if you want. If you do want it, please read https://docs.codethesaur.us to see how to properly create and add the file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[C++] Add queues and stacks
3 participants