Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Akkshay tandon adding c language #659

Conversation

akkshayTandon
Copy link
Contributor

@akkshayTandon akkshayTandon commented Jan 19, 2023

What GitHub issue does this PR apply to?

none

What changed and why?

added strings for C language

Checklist

  • I claimed any associated issue(s) and they are not someone else's
  • I have looked at documentation to ensure I made any revisions correctly
  • I tested my changes locally to ensure they work
  • (If editing Django) I have added or edited any appropriate unit tests for my changes

Any additional comments or things to be aware of while reviewing?

Copy link
Contributor Author

@akkshayTandon akkshayTandon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do I need to do something?

@geekygirlsarah
Copy link
Member

I pulled this PR up yesterday and was getting an error on the project and I couldn't tell if it was from your file or from another PR I merged in, and I wanted to figure that out first. So I need to find that bug first.

@akkshayTandon
Copy link
Contributor Author

Hey @geekygirlsarah can you add a label for C language also?

web/thesauruses/c/17/strings.json Show resolved Hide resolved
web/thesauruses/c/17/strings.json Show resolved Hide resolved
web/thesauruses/c/17/strings.json Show resolved Hide resolved
web/thesauruses/c/17/strings.json Show resolved Hide resolved
web/thesauruses/c/17/strings.json Show resolved Hide resolved
web/thesauruses/c/17/strings.json Show resolved Hide resolved
web/thesauruses/c/17/strings.json Show resolved Hide resolved
web/thesauruses/c/17/strings.json Show resolved Hide resolved
@geekygirlsarah
Copy link
Member

Checking in again to see how this is coming along

@geekygirlsarah
Copy link
Member

Since I haven't heard from you in a while, I'm going to close this PR so someone else can work on the issue.

If you want to take it back on, you're welcome to reopen this PR and pick up where you left off.

@akkshayTandon
Copy link
Contributor Author

He, apologies for not being active. But I have tried to make these changes. I will open a new PR for this one.
My exams are about to start, so might not be able to update the changes actively.

@geekygirlsarah
Copy link
Member

That's fine! I'll leave you on the issue and can see if I can reopen this. (If not, making a new PR is fine.)

@akkshayTandon
Copy link
Contributor Author

I have opened a new PR #714

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants