Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support url with imageExtensions save as same filename #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

chenpx976
Copy link

CleanShot 2023-10-25 at 15 06 31@2x

@codetakki
Copy link
Owner

Hey, Thanks for your Pull request!

I check this out and found that having it always pick the name from the URL can lead to ugly formats:
example:
URL
https://apollo.open-resource.org/_media/mission:log:2014:12:19:github-pull-request-auto-merge-command-line.png
Becomes:
mission:log:2014:12:19:github-pull-request-auto-merge-command-line-2.png

I would not like this in my projects. Can you modify it to be part of the format options instead?
Something like "#{originalfilename}" or similar?

I also think the "extension" part is redundant, as we get the extension based on the header for the download request.

index.js
image

@chenpx976
Copy link
Author

You're right I'll modify the code to use${originalfilename}

@codetakki
Copy link
Owner

@chenpx976 hey just checking in if you solved this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants