Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 2019_09_25_103421_update_task_results_duration_type.php #371

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

jonnott
Copy link
Contributor

@jonnott jonnott commented Jan 26, 2024

  • add missing table name

See #368

@Rowlando13
Copy link

+1 on merging this PR. I just ran into this issue.

@jonnott
Copy link
Contributor Author

jonnott commented Mar 21, 2024

+1 on merging this PR. I just ran into this issue.

You should be able to temporarily fix this yourself by just altering the migration in your project. That's what I did.

@qschmick qschmick merged commit 23e2dcb into codestudiohq:9.0 Mar 21, 2024
1 of 3 checks passed
@jonnott
Copy link
Contributor Author

jonnott commented Mar 21, 2024

Thanks @qschmick .. can you also possibly merge this into the 10.x branch and tag a release there too?

Also, is it possible to switch 10.x to be the main development branch?

@Rowlando13
Copy link

Thanks for the PR and the merge. I editing the migration to resolve it when it happened.

@qschmick
Copy link
Collaborator

@jonnott I can't do that, @roshangautam is the only one with permissions to update the default branch.

@jonnott
Copy link
Contributor Author

jonnott commented Mar 22, 2024

@jonnott I can't do that, @roshangautam is the only one with permissions to update the default branch.

@qschmick Doesn't seem to have been any activity in this project from @roshangautam since 2021 according to GitHub contributions graph.

@roshangautam Are you still active in relation to this project, or otherwise can you give full access permissions to @qschmick so he's able to change the default branch as well as tag/create releases?

@roshangautam
Copy link
Collaborator

@jonnott I can't do that, @roshangautam is the only one with permissions to update the default branch.

@qschmick I have made you an admin of this repo, please let me know if that didn't work. Hope this helps.

jonnott added a commit to jonnott/laravel-totem that referenced this pull request Mar 23, 2024
@jonnott
Copy link
Contributor Author

jonnott commented Mar 23, 2024

@jonnott I can't do that, @roshangautam is the only one with permissions to update the default branch.

@qschmick I have made you an admin of this repo, please let me know if that didn't work. Hope this helps.

Great news .. thanks @roshangautam !

@qschmick If you could switch to 10.x as the default branch, that'd be awesome..

If you could then merge my PRs in this order:

#380
#379
#376

I am happy to do the necessary rebases between these merges if it saves you time..

..then I believe we'd be ready for a new PHP 8.2 / Laravel 11 compatible release!

@jonnott
Copy link
Contributor Author

jonnott commented Mar 24, 2024

If you could then merge my PRs in this order:

#380 #379 #376

Alternatively I could pop all these commits onto one branch and PR that, if that makes it easier..

jonnott added a commit to jonnott/laravel-totem that referenced this pull request Mar 27, 2024
@jonnott
Copy link
Contributor Author

jonnott commented Mar 27, 2024

Alternatively I could pop all these commits onto one branch and PR that, if that makes it easier..

@qschmick I've now made that single PR with all my changes in .. all tests passing: #381

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants