Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASC-393 Refactoring of proxy_test.go #803

Closed
wants to merge 13 commits into from
Prev Previous commit
Next Next commit
Fixes after review
Signed-off-by: Josef Kopriva <[email protected]>
jkopriva committed Oct 6, 2023
commit 939a5e677013e269b2dc84ca78639d49580376fa
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package parallel
package proxy

import (
"context"
@@ -17,7 +17,6 @@ import (
)

func TestSpaceLister(t *testing.T) {
t.Parallel()
// given
awaitilities := WaitForDeployments(t)
hostAwait := awaitilities.Host()

Unchanged files with check annotations Beta

kubewait "k8s.io/apimachinery/pkg/util/wait"
)
type ProxyUser struct {

Check failure on line 26 in testsupport/proxy/proxy_user.go

GitHub Actions / GolangCI Lint

exported: type name will be used as proxy.ProxyUser by other packages, and that stutters; consider calling this User (revive)
ExpectedMemberCluster *wait.MemberAwaitility
Username string
Token string