Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support regexp filter for tests that needs to run #802

Merged
merged 4 commits into from
Oct 3, 2023

Conversation

baijum
Copy link
Contributor

@baijum baijum commented Oct 2, 2023

@openshift-ci
Copy link

openshift-ci bot commented Oct 2, 2023

Hi @baijum. Thanks for your PR.

I'm waiting for a codeready-toolchain member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@mfrancisc mfrancisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

I believe by default keeps running all the tests with -run "" ?

Could you please add few words in the README to document this new variable and how to use it?

@mfrancisc
Copy link
Contributor

/ok-to-test

Signed-off-by: Baiju Muthukadan <[email protected]>
@baijum
Copy link
Contributor Author

baijum commented Oct 2, 2023

I believe by default keeps running all the tests with -run "" ?

Yes. I can see 72 tests passed here. I checked this against a recent build that was merged on last Friday.

Could you please add few words in the README to document this new variable and how to use it?

Done. Please take a look: 7d93534

Copy link
Contributor

@alexeykazakov alexeykazakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

@openshift-ci openshift-ci bot added the approved label Oct 2, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@openshift-ci
Copy link

openshift-ci bot commented Oct 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, baijum, rajivnathan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@MatousJobanek
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 3, 2023
@openshift-ci openshift-ci bot merged commit dfa57d2 into codeready-toolchain:master Oct 3, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants