feat: make SpaceBindingRequest.Spec.MasterUserRecord immutable #792
Conversation
mfrancisc
requested review from
sbryzak,
xcoulon,
alexeykazakov,
MatousJobanek,
rajivnathan and
ranakan19
| //require.Len(t, spacebindingrequestWebhook.Rules, 1) | ||
| // | ||
| //spacebindingrequestRule := spacebindingrequestWebhook.Rules[0] | ||
| //assert.Equal(t, []admv1.OperationType{admv1.Create, admv1.Update}, spacebindingrequestRule.Operations) |
There was a problem hiding this comment.
please don't forget to add the patch as proposed in the other PR
There was a problem hiding this comment.
Unless I've missed it there is not PATCH , plz see codeready-toolchain/member-operator#470 (comment) 🤷♂️
There was a problem hiding this comment.
I see now - thanks for the link and your answer there 👍
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MatousJobanek, mfrancisc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Kudos, SonarCloud Quality Gate passed!
|
Update spacebindingrequest_test in order to ensure SpaceBindingRequest.Spec.MasterUserRecord cannot be updated.
Jira: https://issues.redhat.com/browse/ASC-426
Paired with: codeready-toolchain/member-operator#470