Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update OWNERS file #1083

Merged
merged 3 commits into from
Dec 11, 2024
Merged

update OWNERS file #1083

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0943acf
update_owners_file
rsoaresd Dec 10, 2024
73dcd46
Merge branch 'master' into update_toolchain-e2e_owners_file
rsoaresd Dec 10, 2024
e27d960
remove unnecessary lines
rsoaresd Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions OWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,17 +3,21 @@
approvers:
- alexeykazakov
- MatousJobanek
- sbryzak
- xcoulon
- rajivnathan
- ranakan19
- mfrancisc
- fbm3307
- metlos
- rsoaresd

reviewers:
- alexeykazakov
- MatousJobanek
- sbryzak
- xcoulon
- rajivnathan
- ranakan19
- mfrancisc
- mfrancisc
- fbm3307
- metlos
- rsoaresd
1 change: 0 additions & 1 deletion test/e2e/parallel/spacebindingrequest_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,6 @@ func TestCreateSpaceBindingRequest(t *testing.T) {
})

t.Run("error", func(t *testing.T) {

t.Run("unable create space binding request with invalid SpaceRole", func(t *testing.T) {
user1 := NewSignupRequest(awaitilities).
ManuallyApprove().
Expand Down
1 change: 0 additions & 1 deletion test/e2e/parallel/vm_webhook_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@ func TestCreateVirtualMachine(t *testing.T) {
},
} {
t.Run(tcname, func(t *testing.T) {

// create a user for each scenario to avoid vm quota limit
username := fmt.Sprintf("test-vm-%d", userCounter)
useremail := fmt.Sprintf("%[email protected]", username)
Expand Down
1 change: 0 additions & 1 deletion testsupport/user_setup.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ func createMultipleSignups(t *testing.T, awaitilities wait.Awaitilities, targetC

user := signupRequest.Execute(t)
signups[i] = user.UserSignup

}
return signups
}
Expand Down
1 change: 0 additions & 1 deletion testsupport/wait/awaitility.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -440,7 +440,6 @@ func (a *Awaitility) WaitForDeploymentToGetReady(t *testing.T, name string, repl
t.Logf("waiting until deployment '%s' in namespace '%s' is ready", name, a.Namespace)
deployment := &appsv1.Deployment{}
err := wait.PollUntilContextTimeout(context.TODO(), a.RetryInterval, 6*a.Timeout, true, func(ctx context.Context) (done bool, err error) {

obj := &appsv1.Deployment{}
if err := a.Client.Get(context.TODO(), types.NamespacedName{Namespace: a.Namespace, Name: name}, obj); err != nil {
if apierrors.IsNotFound(err) {
Expand Down
Loading