SANDBOX-770: fix WaitForBannedUser

[rsoaresd]

Description

This function is not used in toolchain-e2e. However, it will be useful for WA.
Unfortunately, it was not working as expected since when no error on list, it was accessing &bannedUserList.Items[0] without checking the array length.

Issue ticket number and link

SANDBOX-770

[alexeykazakov]

Alternately we could move it to WA but I'm fine with keeping it here in case we need it use in the main e2e tests later too.

[mfrancisc]

Looks good 👍

[rsoaresd]

Alternately we could move it to WA but I'm fine with keeping it here in case we need it use in the main e2e tests later too.

@alexeykazakov I did not move it because I do not know if that function is there for some reason. I tried to track when it was added but i was not able. i think it was added a long time ago

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, mfrancisc, rajivnathan, rsoaresd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [alexeykazakov,mfrancisc,rajivnathan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment