Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: clean unused vars #1069

Merged
merged 2 commits into from
Nov 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion make/dev.mk
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
DEV_SSO_NS := toolchain-dev-sso
DEV_ENVIRONMENT := dev

DEFAULT_HOST_NS= toolchain-host-operator
DEFAULT_MEMBER_NS= toolchain-member-operator
DEFAULT_MEMBER_NS_2= toolchain-member2-operator
SHOW_CLEAN_COMMAND="make clean-dev-resources"

.PHONY: dev-deploy-latest
Expand Down
5 changes: 0 additions & 5 deletions make/test.mk
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@ QUAY_NAMESPACE ?= codeready-toolchain-test
DATE_SUFFIX := $(shell date +'%d%H%M%S')
HOST_NS ?= toolchain-host-${DATE_SUFFIX}
MEMBER_NS ?= toolchain-member-${DATE_SUFFIX}
DEFAULT_HOST_NS= toolchain-host-operator
DEFAULT_MEMBER_NS= toolchain-member-operator
DEFAULT_MEMBER_NS_2= toolchain-member2-operator
# it can be used to customize the install wait timeout parameter for the ksctl adm install-operator
# for eg. on slow systems you can customize it like so: KSCTL_INSTALL_TIMEOUT_PARAM="--timeout=15m"
KSCTL_INSTALL_TIMEOUT_PARAM ?= ""
Expand Down Expand Up @@ -271,8 +268,6 @@ setup-toolchainclusters: ksctl
echo "Restart host operator pods so it can get the ToolchainCluster CRs while it's starting up".
oc delete pods --namespace ${HOST_NS} -l control-plane=controller-manager

E2E_MEMBER_NS := toolchain-member-operator
E2E_HOST_NS := toolchain-host-operator

.PHONY: deploy-single-member-e2e
## Deploy operators in e2e mode with single member without running tests
Expand Down
Loading