Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: KUBESAW-236 update ci scripts #1065

Merged
merged 6 commits into from
Nov 25, 2024

Conversation

rsoaresd
Copy link
Contributor

@rsoaresd rsoaresd commented Nov 18, 2024

Description

  • clean OWNER_AND_BRANCH_LOCATION
  • cleanup the pull mechanism in scripts/ci/manage-host-operator.sh and scripts/ci/manage-member-operator.sh (thanks @MatousJobanek)
  • delete scripts/ci/collect-logs.sh since we do not use it

P.S. Once this PR is merged, I will delete scripts/ci folder on toolchain-cicd

Issue ticket number and link

KUBESAW-236

@rsoaresd
Copy link
Contributor Author

rsoaresd commented Nov 19, 2024

/retest

   user_management_test.go:282: 
        	Error Trace:	/go/src/github.com/codeready-toolchain/toolchain-e2e/test/e2e/user_management_test.go:282
        	Error:      	Received unexpected error:
        	            	context deadline exceeded
        	Test:       	TestUserManagement/TestUserDeactivation/tests_for_tiers_with_automatic_deactivation_enabled

Maybe flaky test. Just found 2 occurrences

@rsoaresd
Copy link
Contributor Author

rsoaresd commented Nov 19, 2024

/retest

    proxy_test.go:385: 
        	Error Trace:	/go/src/github.com/codeready-toolchain/toolchain-e2e/test/e2e/parallel/proxy_test.go:385
        	Error:      	Received unexpected error:
        	            	configmaps "kube-root-ca.crt" not found
        	Test:       	TestProxyFlow/compliant.username/get_resource_from_namespace_outside_of_user's_workspace/success_when_accessing_shared_namespace/using_explicit_workspace_context

First time I came across this. Maybe a flaky test (?)

Copy link
Contributor

@mfrancisc mfrancisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Job 👍

Thanks for simplifying and cleaning this up 🙏

Copy link
Collaborator

@MatousJobanek MatousJobanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool 👍 Thanks 🥇

Copy link

openshift-ci bot commented Nov 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MatousJobanek, mfrancisc, rsoaresd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [MatousJobanek,mfrancisc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rsoaresd rsoaresd merged commit 6162287 into codeready-toolchain:master Nov 25, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants