Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Use LabelsAndGenerationPredicate for ToolchainClusterCache co… #438

Merged

Conversation

rajivnathan
Copy link
Contributor

@rajivnathan rajivnathan commented Dec 11, 2024

…ntroller (#437)"

This reverts commit 463b623.

It breaks the cluster status checks. See the discussion https://redhat-internal.slack.com/archives/C06MJ2DVBU4/p1733903646722119?thread_ts=1733844483.420089&cid=C06MJ2DVBU4

Copy link

sonarcloud bot commented Dec 11, 2024

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.23%. Comparing base (a6a8525) to head (6d16802).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...nclustercache/toolchaincluster_cache_controller.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #438   +/-   ##
=======================================
  Coverage   78.23%   78.23%           
=======================================
  Files          49       49           
  Lines        2444     2444           
=======================================
  Hits         1912     1912           
  Misses        478      478           
  Partials       54       54           
Files with missing lines Coverage Δ
...nclustercache/toolchaincluster_cache_controller.go 48.14% <0.00%> (ø)

@rajivnathan rajivnathan merged commit 1282865 into codeready-toolchain:master Dec 11, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants