improve IsAlreadyBanned

[rsoaresd]

Description

• improve IsAlreadyBanned func to return the BannedUser when the user was already banned
• fix some assertions and clean imports being imported more than once

Issue ticket number and link

SANDBOX-674

Associated PRs:

• wa 12

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.47%. Comparing base (c8ee880) to head (7d9fe84).

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #416      +/-   ##
==========================================
+ Coverage   78.45%   78.47%   +0.02%     
==========================================
  Files          48       48              
  Lines        2010     2012       +2     
==========================================
+ Hits         1577     1579       +2     
  Misses        375      375              
  Partials       58       58              

Files	Coverage Δ
...rs/toolchaincluster/toolchaincluster_controller.go	82.24% <100.00%> (ø)
pkg/banneduser/banneduser.go	100.00% <100.00%> (ø)

[alexeykazakov]

Looks good but it probably would make sense to rename the function.

[rajivnathan]

Looks good once we've renamed the function