Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SANDBOX-677 use go-version-file #415

Merged

Conversation

ranakan19
Copy link
Contributor

@ranakan19 ranakan19 commented Jul 15, 2024

uses go-version-file instead of go-version. One less place to change when making updates.
Changes order in github action to first checkout code and then install go.

related PRs:
codeready-toolchain/api#434

Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.15%. Comparing base (8604fe4) to head (d95b849).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #415   +/-   ##
=======================================
  Coverage   78.15%   78.15%           
=======================================
  Files          47       47           
  Lines        1982     1982           
=======================================
  Hits         1549     1549           
  Misses        375      375           
  Partials       58       58           

Copy link
Contributor

@fbm3307 fbm3307 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link

@MatousJobanek MatousJobanek merged commit 2f6e6a3 into codeready-toolchain:master Jul 22, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants