-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SANDBOX-677 use go-version-file #415
Merged
MatousJobanek
merged 4 commits into
codeready-toolchain:master
from
ranakan19:go-version-file-common
Jul 22, 2024
Merged
SANDBOX-677 use go-version-file #415
MatousJobanek
merged 4 commits into
codeready-toolchain:master
from
ranakan19:go-version-file-common
Jul 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranakan19
requested review from
MatousJobanek,
xcoulon,
alexeykazakov,
rajivnathan,
sbryzak and
mfrancisc
as code owners
July 15, 2024 20:19
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #415 +/- ##
=======================================
Coverage 78.15% 78.15%
=======================================
Files 47 47
Lines 1982 1982
=======================================
Hits 1549 1549
Misses 375 375
Partials 58 58 |
This was referenced Jul 15, 2024
alexeykazakov
approved these changes
Jul 16, 2024
fbm3307
approved these changes
Jul 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
MatousJobanek
approved these changes
Jul 22, 2024
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uses go-version-file instead of go-version. One less place to change when making updates.
Changes order in github action to first checkout code and then install go.
related PRs:
codeready-toolchain/api#434