-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add kubesaw-authenticated username constant #394
add kubesaw-authenticated username constant #394
Conversation
Signed-off-by: Francesco Ilario <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #394 +/- ##
=======================================
Coverage 77.98% 77.98%
=======================================
Files 47 47
Lines 1958 1958
=======================================
Hits 1527 1527
Misses 373 373
Partials 58 58 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we want to move it to API instead: https://github.com/codeready-toolchain/api/tree/master/api/v1alpha1/auth.go
WDYT? @MatousJobanek
Yes, let's move this constant to the api repository:
|
Quality Gate passedIssues Measures |
closing this PR as superseded by codeready-toolchain/api#418 |
JIRA: https://issues.redhat.com/browse/ASC-531
Add constant value for the 'kubesaw-authenticated' special user
Signed-off-by: Francesco Ilario [email protected]