Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add kubesaw-authenticated username constant #394

Conversation

filariow
Copy link
Contributor

JIRA: https://issues.redhat.com/browse/ASC-531

Add constant value for the 'kubesaw-authenticated' special user

Signed-off-by: Francesco Ilario [email protected]

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.98%. Comparing base (78585f7) to head (d06900a).

❗ Current head d06900a differs from pull request most recent head b21ca21. Consider uploading reports for the commit b21ca21 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #394   +/-   ##
=======================================
  Coverage   77.98%   77.98%           
=======================================
  Files          47       47           
  Lines        1958     1958           
=======================================
  Hits         1527     1527           
  Misses        373      373           
  Partials       58       58           

Copy link
Collaborator

@alexeykazakov alexeykazakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MatousJobanek
Copy link
Contributor

MatousJobanek commented Apr 30, 2024

Yes, let's move this constant to the api repository:

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@filariow
Copy link
Contributor Author

filariow commented Apr 30, 2024

closing this PR as superseded by codeready-toolchain/api#418

@filariow filariow closed this Apr 30, 2024
@filariow filariow deleted the pv-531-kubesaw-authenticated-const branch May 20, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants