Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add .gitleaks.toml #393

Merged
merged 6 commits into from
Apr 29, 2024
Merged

Conversation

filariow
Copy link
Contributor

@filariow filariow commented Apr 29, 2024

This PR excludes the file pkg/test/auth/tokenmanager.go from the GitLeaks checks. It is actually containing a certificate that prevents the git hook to complete successfully.

Signed-off-by: Francesco Ilario [email protected]

Signed-off-by: Francesco Ilario <[email protected]>
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.98%. Comparing base (78746c9) to head (62a4943).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #393   +/-   ##
=======================================
  Coverage   77.98%   77.98%           
=======================================
  Files          47       47           
  Lines        1958     1958           
=======================================
  Hits         1527     1527           
  Misses        373      373           
  Partials       58       58           

Signed-off-by: Francesco Ilario <[email protected]>
Signed-off-by: Francesco Ilario <[email protected]>
@filariow filariow requested a review from mfrancisc April 29, 2024 12:48
Signed-off-by: Francesco Ilario <[email protected]>
@filariow filariow changed the title add .gitleaks.toml remove embedded certificate in pkg/test/auth/tokenmanager.go Apr 29, 2024
This reverts commit 84e806b.
@filariow filariow changed the title remove embedded certificate in pkg/test/auth/tokenmanager.go add .gitleaks.toml Apr 29, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@alexeykazakov alexeykazakov merged commit 78585f7 into codeready-toolchain:master Apr 29, 2024
8 checks passed
@filariow filariow deleted the add-gitleaks branch April 30, 2024 13:04
fbm3307 pushed a commit to fbm3307/toolchain-common that referenced this pull request May 2, 2024
* add .gitleaks.toml

Signed-off-by: Francesco Ilario <[email protected]>

* update .gitleaks.toml

Signed-off-by: Francesco Ilario <[email protected]>

* remove e2e embedded cert

Signed-off-by: Francesco Ilario <[email protected]>

* refactor

Signed-off-by: Francesco Ilario <[email protected]>

* Revert "refactor"

This reverts commit 84e806b.

* Revert "remove e2e embedded cert"

This reverts commit 750e6ce.

---------

Signed-off-by: Francesco Ilario <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants