-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add .gitleaks.toml #393
Merged
alexeykazakov
merged 6 commits into
codeready-toolchain:master
from
filariow:add-gitleaks
Apr 29, 2024
Merged
add .gitleaks.toml #393
alexeykazakov
merged 6 commits into
codeready-toolchain:master
from
filariow:add-gitleaks
Apr 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Francesco Ilario <[email protected]>
filariow
requested review from
MatousJobanek,
xcoulon,
alexeykazakov,
rajivnathan,
ranakan19,
sbryzak and
mfrancisc
as code owners
April 29, 2024 12:35
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #393 +/- ##
=======================================
Coverage 77.98% 77.98%
=======================================
Files 47 47
Lines 1958 1958
=======================================
Hits 1527 1527
Misses 373 373
Partials 58 58 |
Signed-off-by: Francesco Ilario <[email protected]>
mfrancisc
approved these changes
Apr 29, 2024
Signed-off-by: Francesco Ilario <[email protected]>
Signed-off-by: Francesco Ilario <[email protected]>
filariow
changed the title
add .gitleaks.toml
remove embedded certificate in pkg/test/auth/tokenmanager.go
Apr 29, 2024
This was referenced Apr 29, 2024
filariow
changed the title
remove embedded certificate in pkg/test/auth/tokenmanager.go
add .gitleaks.toml
Apr 29, 2024
Quality Gate passedIssues Measures |
mfrancisc
approved these changes
Apr 29, 2024
alexeykazakov
approved these changes
Apr 29, 2024
fbm3307
pushed a commit
to fbm3307/toolchain-common
that referenced
this pull request
May 2, 2024
* add .gitleaks.toml Signed-off-by: Francesco Ilario <[email protected]> * update .gitleaks.toml Signed-off-by: Francesco Ilario <[email protected]> * remove e2e embedded cert Signed-off-by: Francesco Ilario <[email protected]> * refactor Signed-off-by: Francesco Ilario <[email protected]> * Revert "refactor" This reverts commit 84e806b. * Revert "remove e2e embedded cert" This reverts commit 750e6ce. --------- Signed-off-by: Francesco Ilario <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR excludes the file
pkg/test/auth/tokenmanager.go
from the GitLeaks checks. It is actually containing a certificate that prevents the git hook to complete successfully.Signed-off-by: Francesco Ilario [email protected]