remove webConsolePlugin from ToolchainClusterConfig (phase 1) #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phase 1: only remove the CRD Signed-off-by: Xavier Coulon <[email protected]>
xcoulon
requested review from
MatousJobanek,
alexeykazakov,
rajivnathan,
ranakan19,
sbryzak and
mfrancisc
as code owners
|
xcoulon
added a commit
to xcoulon/toolchain-e2e
that referenced
this pull request
Jul 29, 2024
phase 1: only remove the CRD in host-operator also, remove outdated e2e tests and makefile bits see also: - codeready-toolchain/member-operator#589 - codeready-toolchain/host-operator#1069 Signed-off-by: Xavier Coulon <[email protected]>
This was referenced Jul 29, 2024
remove webConsolePlugin from ToolchainClusterConfig (phase 1)
codeready-toolchain/toolchain-e2e#1021
Closed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #589 +/- ##
=======================================
Coverage 83.32% 83.32%
=======================================
Files 31 31
Lines 2704 2704
=======================================
Hits 2253 2253
Misses 304 304
Partials 147 147 |
alexeykazakov
approved these changes
Jul 29, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexeykazakov, xcoulon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
xcoulon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
phase 1: only remove the CRD
Signed-off-by: Xavier Coulon [email protected]