Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove kubernetesimagepuller webhook #526

Merged
merged 3 commits into from
Jan 23, 2024

Conversation

dkwon17
Copy link
Contributor

@dkwon17 dkwon17 commented Jan 18, 2024

Removes the kubernetesimagepuller webhook introduced in #493

Since the Kubernetes Image Puller Operator v1.1.0 provides its own webhook to limit image puller resources, this webhook on the member-operator side is not needed anymore.

Copy link

openshift-ci bot commented Jan 18, 2024

Hi @dkwon17. Thanks for your PR.

I'm waiting for a codeready-toolchain member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: David Kwon <[email protected]>
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
6.4% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Merging #526 (dac8983) into master (951ec03) will increase coverage by 0.68%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #526      +/-   ##
==========================================
+ Coverage   82.54%   83.22%   +0.68%     
==========================================
  Files          29       28       -1     
  Lines        3220     3178      -42     
==========================================
- Hits         2658     2645      -13     
+ Misses        426      399      -27     
+ Partials      136      134       -2     

Copy link

openshift-ci bot commented Jan 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, dkwon17

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@alexeykazakov
Copy link
Contributor

/ok-to-test

@alexeykazakov alexeykazakov merged commit 37fba83 into codeready-toolchain:master Jan 23, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants