Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

complete bad fix #492

Conversation

mmulholla
Copy link
Contributor

The code was getting the toolchain-e2e branch name ok but using the wrong variable to fetch it.

Copy link

sonarqubecloud bot commented Nov 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

openshift-ci bot commented Nov 1, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mmulholla, rajivnathan
Once this PR has been reviewed and has the lgtm label, please assign alexeykazakov for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rajivnathan
Copy link
Contributor

/lgtm

@rajivnathan
Copy link
Contributor

/approved

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #492 (7f308b7) into master (6669ed5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #492   +/-   ##
=======================================
  Coverage   82.44%   82.44%           
=======================================
  Files          30       30           
  Lines        3178     3178           
=======================================
  Hits         2620     2620           
  Misses        426      426           
  Partials      132      132           

@rajivnathan rajivnathan merged commit 8acdc3c into codeready-toolchain:master Nov 1, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants