Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable HTTP/2 on kube-rbac-proxy container #488

Conversation

xcoulon
Copy link
Contributor

@xcoulon xcoulon commented Oct 25, 2023

Signed-off-by: Xavier Coulon [email protected]

@openshift-ci
Copy link

openshift-ci bot commented Oct 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, MatousJobanek, rajivnathan, ranakan19, xcoulon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [MatousJobanek,alexeykazakov,xcoulon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@alexeykazakov
Copy link
Contributor

/lgtm

@xcoulon
Copy link
Contributor Author

xcoulon commented Oct 26, 2023

/test e2e

Signed-off-by: Xavier Coulon <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm label Oct 26, 2023
@openshift-ci
Copy link

openshift-ci bot commented Oct 26, 2023

New changes are detected. LGTM label has been removed.

@xcoulon
Copy link
Contributor Author

xcoulon commented Oct 26, 2023

@xcoulon xcoulon marked this pull request as draft October 26, 2023 12:29
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #488 (23c9ee6) into master (794aeaa) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #488   +/-   ##
=======================================
  Coverage   82.35%   82.35%           
=======================================
  Files          30       30           
  Lines        3270     3270           
=======================================
  Hits         2693     2693           
  Misses        440      440           
  Partials      137      137           

Signed-off-by: Xavier Coulon <[email protected]>
@xcoulon xcoulon force-pushed the kube_rbac_proxy_disablehttp2_member branch from 18a270c to 23c9ee6 Compare November 2, 2023 09:55
Copy link

sonarqubecloud bot commented Nov 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
9.4% 9.4% Duplication

@xcoulon xcoulon marked this pull request as ready for review November 2, 2023 12:26
@openshift-ci openshift-ci bot requested a review from MatousJobanek November 2, 2023 12:26
@xcoulon xcoulon merged commit a10d84e into codeready-toolchain:master Nov 2, 2023
11 checks passed
@xcoulon xcoulon deleted the kube_rbac_proxy_disablehttp2_member branch November 2, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants