-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ingress network policy with generic sandbox label #1113
Open
mfrancisc
wants to merge
25
commits into
codeready-toolchain:master
Choose a base branch
from
mfrancisc:allowfromdevsandboxmanaged
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+78
−0
Open
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
8d24435
remove spacebinding request migration controller
mfrancisc a25fb02
Merge branch 'master' of github.com:mfrancisc/host-operator
mfrancisc fd840c6
Merge branch 'master' of github.com:mfrancisc/host-operator
mfrancisc 0221d40
Merge branch 'master' of github.com:mfrancisc/host-operator
mfrancisc 0f4717d
Merge branch 'master' of github.com:mfrancisc/host-operator
mfrancisc 0977ae6
Merge branch 'master' of github.com:mfrancisc/host-operator
mfrancisc 7aa35c5
Merge branch 'master' of github.com:mfrancisc/host-operator
mfrancisc d09f3b8
Merge branch 'master' of github.com:mfrancisc/host-operator
mfrancisc 79c20ca
Merge branch 'master' of github.com:mfrancisc/host-operator
mfrancisc b21f39f
Merge branch 'master' of github.com:mfrancisc/host-operator
mfrancisc b0aea00
Merge branch 'master' of github.com:mfrancisc/host-operator
mfrancisc e9e35bc
Merge branch 'master' of github.com:mfrancisc/host-operator
mfrancisc 969562e
Merge branch 'master' of github.com:mfrancisc/host-operator
344bc04
Merge branch 'master' of github.com:mfrancisc/host-operator
ea71877
Merge branch 'master' of github.com:mfrancisc/host-operator
ef294f7
Merge branch 'master' of github.com:mfrancisc/host-operator
1f8d51d
Merge branch 'master' of github.com:mfrancisc/host-operator
b27cde7
Merge branch 'master' of github.com:mfrancisc/host-operator
bbb2689
Merge branch 'master' of github.com:mfrancisc/host-operator
ec51de9
Merge branch 'master' of github.com:mfrancisc/host-operator
cc3a260
Merge branch 'master' of github.com:mfrancisc/host-operator
ed8eeea
allow from dev sandbox managed NS
72d7fe7
Update deploy/templates/nstemplatetiers/base/ns_dev.yaml
mfrancisc cf5a1a4
fix typo
ec0bb86
Merge remote-tracking branch 'origin/allowfromdevsandboxmanaged' into…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -197,6 +197,19 @@ objects: | |
podSelector: {} | ||
policyTypes: | ||
- Ingress | ||
- apiVersion: networking.k8s.io/v1 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We don't have to modify the test tier. But it won't heart to add it here too. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ok, makes sense. I wasn't sure, just wanted to be consitent. |
||
kind: NetworkPolicy | ||
metadata: | ||
name: allow-from-dev-sandbox-managed-ns | ||
namespace: ${SPACE_NAME}-dev | ||
spec: | ||
ingress: | ||
- from: | ||
- namespaceSelector: | ||
matchLabels: | ||
dev-sandbox/policy-group: ingress | ||
policyTypes: | ||
- Ingress | ||
parameters: | ||
- name: SPACE_NAME | ||
required: true | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, we need to delete all intel tiers :) But let's do it in a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got it, I'll open a new one, once those are merged!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we keep them , just in case they might be used by the intel team for their own kubesaw instance ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can always revert the cleanup PRs later if needed. But most likely we won't need these tiers anytime soon.