Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add parameters to the TierTemplateRevision CRD #451

Merged
merged 7 commits into from
Dec 2, 2024

Conversation

mfrancisc
Copy link
Contributor

@mfrancisc mfrancisc commented Nov 28, 2024

Description

In order to parse the TierTemplate content only once ( when provisioning a space with the given tier) , we are introducing the parameter list to the TierTemplateRevision CRD.

The parameters will be copied from the NSTemplateTier when generating the TTR, and they will be used for:

  • comparison with those in the NSTemplateTier, to identify if something has changed and generate a new TTR
  • when provisioning/updating the Space , those parameters ( together with the dynamic ones like "SPACE_NAME" ) will be used to evaluate the variables present in the TierTemplateRevision.Spec.TemplateObjects

Checks

  1. Did you run make generate target? yes

  2. Did make generate change anything in other projects (host-operator, member-operator)? yes

  3. In case of new CRD, did you the following? N/A

  4. In case other projects are changed, please provides PR links.

Copy link

sonarcloud bot commented Nov 28, 2024

@mfrancisc mfrancisc merged commit 5453178 into codeready-toolchain:master Dec 2, 2024
3 checks passed
@mfrancisc mfrancisc deleted the addparamsinttr branch December 2, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants