refactor: upgrade organizer controllers to 1.7

lib/bokken_web/controllers/organizer_controller.ex → lib/bokken_web/controllers/organizer/organizer_controller.ex

@@ -1,5 +1,5 @@
 defmodule BokkenWeb.OrganizerController do
-  use BokkenWeb, controller: "1.6"
+  use BokkenWeb, :controller
 
   alias Bokken.Accounts
   alias Bokken.Accounts.Organizer
@@ -8,29 +8,29 @@ defmodule BokkenWeb.OrganizerController do
 
   def index(conn, _params) do
     organizers = Accounts.list_organizers()
-    render(conn, "index.json", organizers: organizers)
+    render(conn, :index, organizers: organizers)
   end
 
   def create(conn, %{"organizer" => organizer_params}) when is_organizer(conn) do
     with {:ok, %Organizer{} = organizer} <- Accounts.create_organizer(organizer_params) do
       conn
       |> put_status(:created)
-      |> put_resp_header("location", Routes.organizer_path(conn, :show, organizer))
-      |> render("show.json", organizer: organizer)
+      |> put_resp_header("location", ~p"/api/organizers/#{organizer}")
+      |> render(:show, organizer: organizer)
     end
   end
 
   def show(conn, %{"id" => id}) do
     organizer = Accounts.get_organizer!(id)
-    render(conn, "show.json", organizer: organizer)
+    render(conn, :show, organizer: organizer)
   end
 
   def update(conn, %{"id" => id, "organizer" => organizer_params})
       when is_organizer(conn) do
     organizer = Accounts.get_organizer!(id)
 
     with {:ok, %Organizer{} = organizer} <- Accounts.update_organizer(organizer, organizer_params) do
-      render(conn, "show.json", organizer: organizer)
+      render(conn, :show, organizer: organizer)
     end
   end
 

lib/bokken_web/controllers/organizer/organizer_json.ex

@@ -0,0 +1,18 @@
+defmodule BokkenWeb.OrganizerJSON do
+  def index(%{organizers: organizers}) do
+    %{data: for(organizer <- organizers, do: data(organizer))}
+  end
+
+  def show(%{organizer: organizer}) do
+    %{data: data(organizer)}
+  end
+
+  def data(organizer) do
+    %{
+      id: organizer.id,
+      champion: organizer.champion,
+      first_name: organizer.first_name,
+      last_name: organizer.last_name
+    }
+  end
+end

lib/bokken_web/views/auth_view.ex

@@ -5,7 +5,7 @@ defmodule BokkenWeb.AuthView do
   alias BokkenWeb.GuardianView
   alias BokkenWeb.MentorView
   alias BokkenWeb.NinjaView
-  alias BokkenWeb.OrganizerView
+  alias BokkenWeb.OrganizerJSON
 
   def render("me.json", %{user: %{registered: false} = user}) do
     render_one(user, AuthView, "user.json")
@@ -30,7 +30,7 @@ defmodule BokkenWeb.AuthView do
   end
 
   def render("me.json", %{user: %{role: :organizer, organizer: organizer} = user}) do
-    render_one(organizer, OrganizerView, "organizer.json")
+    render_one(organizer, OrganizerJSON, "organizer.json")
     |> Map.merge(render_one(user, AuthView, "user.json", current_user: user))
     |> Map.put(:organizer_id, organizer.id)
   end

test/bokken_web/controllers/organizer_json_test.exs

@@ -0,0 +1,36 @@
+defmodule Bokken.OrganizerJSONTest do
+  use Bokken.DataCase
+
+  import Bokken.Factory
+  alias BokkenWeb.OrganizerJSON
+
+  test "data" do
+    organizer = build(:organizer)
+    rendered_organizer = OrganizerJSON.data(organizer)
+
+    assert rendered_organizer == %{
+             id: organizer.id,
+             champion: organizer.champion,
+             first_name: organizer.first_name,
+             last_name: organizer.last_name
+           }
+  end
+
+  test "show" do
+    organizer = build(:organizer)
+    rendered_organizer = OrganizerJSON.show(%{organizer: organizer})
+
+    assert rendered_organizer == %{
+             data: OrganizerJSON.data(organizer)
+           }
+  end
+
+  test "index" do
+    organizers = build_list(5, :organizer)
+    rendered_organizers = OrganizerJSON.index(%{organizers: organizers})
+
+    assert rendered_organizers == %{
+             data: Enum.map(organizers, &OrganizerJSON.data(&1))
+           }
+  end
+end