Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node.js has a built-in
util.isDeepStrictEqual
since v9.0.0: https://nodejs.org/docs/latest-v21.x/api/assert.html#assertdeepstrictequalactual-expected-messageThis is helpful because the
deep-equal
package has 50 dependencies, mostly ponyfills. We can make supertape have 34% fewer dependencies and 18% less installed filesize just by using the built in function instead of thedeep-equal
package.However, this change makes it go from a loosely equal comparison to a strictly equal comparison, which could affect people's tests. (I had to fix one of mine that was expecting
null
but actually gotundefined
.) So a major version bump to v11 will be required.