Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

work-item strided transforms #136

Merged
merged 13 commits into from
Feb 9, 2024
Merged

work-item strided transforms #136

merged 13 commits into from
Feb 9, 2024

Conversation

FMarno
Copy link
Contributor

@FMarno FMarno commented Jan 30, 2024 •
edited
Loading

Adds work-item level strided ffts.
This includes support for arbitrary strides and distances for 1D transforms, layout validation, and validation tests.

Checklist

Tick if relevant:

  • New files have a copyright
  • New headers have an include guards
  • API is documented with Doxygen
  • New functionalities are tested
  • Tests pass locally
  • Files are clang-formatted

AD2605
AD2605 reviewed Jan 31, 2024
View reviewed changes
src/portfft/descriptor.hpp Outdated Show resolved Hide resolved
src/portfft/descriptor.hpp Outdated Show resolved Hide resolved
src/portfft/common/transfers.hpp Outdated Show resolved Hide resolved
src/portfft/descriptor.hpp Outdated Show resolved Hide resolved
src/portfft/descriptor.hpp Outdated Show resolved Hide resolved
src/portfft/dispatcher/workitem_dispatcher.hpp Outdated Show resolved Hide resolved
test/unit_test/fft_test_utils.hpp Outdated Show resolved Hide resolved
src/portfft/descriptor_validate.hpp Outdated Show resolved Hide resolved
src/portfft/dispatcher/workitem_dispatcher.hpp Outdated Show resolved Hide resolved
src/portfft/descriptor.hpp Outdated Show resolved Hide resolved
t4c1
t4c1 requested changes Feb 1, 2024
View reviewed changes
src/portfft/common/logging.hpp Outdated Show resolved Hide resolved
src/portfft/descriptor.hpp Outdated Show resolved Hide resolved
src/portfft/descriptor_validate.hpp Outdated Show resolved Hide resolved
src/portfft/dispatcher/workitem_dispatcher.hpp Outdated Show resolved Hide resolved
test/common/reference_data_wrangler.hpp Show resolved Hide resolved
Rbiessy
Rbiessy reviewed Feb 5, 2024
View reviewed changes
src/portfft/descriptor_validate.hpp Outdated Show resolved Hide resolved
src/portfft/committed_descriptor_impl.hpp Outdated Show resolved Hide resolved
src/portfft/dispatcher/workitem_dispatcher.hpp Outdated Show resolved Hide resolved
src/portfft/dispatcher/workitem_dispatcher.hpp Outdated Show resolved Hide resolved
src/portfft/enums.hpp Outdated Show resolved Hide resolved
test/common/reference_data_wrangler.hpp Outdated Show resolved Hide resolved
test/unit_test/fft_test_utils.hpp Outdated Show resolved Hide resolved
test/unit_test/instantiate_fft_tests.hpp Outdated Show resolved Hide resolved
t4c1
t4c1 approved these changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@t4c1 t4c1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming addressing other comments did not break anything.

@FMarno FMarno merged commit 324a88f into main Feb 9, 2024
1 check passed
@FMarno FMarno deleted the finlay/strided branch February 9, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AD2605 AD2605 AD2605 approved these changes

@Rbiessy Rbiessy Rbiessy approved these changes

@t4c1 t4c1 t4c1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@FMarno @t4c1 @Rbiessy @AD2605