Another attempt to fix socket memory leak

Ideally should fix both #3726 and the regression in #3753
codenameone · Oct 28, 2023 · c53f629 · c53f629
1 parent 39f3132
commit c53f629
Showing 1 changed file with 11 additions and 9 deletions.
diff --git a/CodenameOne/src/com/codename1/io/Socket.java b/CodenameOne/src/com/codename1/io/Socket.java
@@ -211,11 +211,13 @@ public synchronized void reset() throws IOException {
         }
 
         @Override
-        public void close() throws IOException {
-            closed = true;
-            if(Util.getImplementation().isSocketConnected(impl)) {
-                Util.getImplementation().disconnectSocket(impl);
-                con.setConnected(false);
+        public synchronized void close() throws IOException {
+            if(!closed) {
+                closed = true;
+                if (Util.getImplementation().isSocketConnected(impl)) {
+                    Util.getImplementation().disconnectSocket(impl);
+                    con.setConnected(false);
+                }
             }
         }
 
@@ -335,7 +337,7 @@ public int read() throws IOException {
         protected void finalize() throws Throwable {
             try {
                 close();
-            } catch (IOException err) {
+            } catch (Throwable err) {
                 Log.e(err);
             }
         }
@@ -350,8 +352,8 @@ static class SocketOutputStream extends OutputStream {
         }
 
         @Override
-        public void close() throws IOException {
-            if(Util.getImplementation().isSocketConnected(impl)) {
+        public synchronized void close() throws IOException {
+            if (con.isConnected() && Util.getImplementation().isSocketConnected(impl)) {
                 Util.getImplementation().disconnectSocket(impl);
                 con.setConnected(false);
             }
@@ -397,7 +399,7 @@ public void write(int b) throws IOException {
         protected void finalize() throws Throwable {
             try {
                 close();
-            } catch (IOException err) {
+            } catch (Throwable err) {
                 Log.e(err);
             }
         }