Fix filtering objects when filter contains both source files and other object types #2457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrjorgensen
added
the
bug
chrjorgensen
requested changes
Jan 22, 2025
There was a problem hiding this comment.
@janfh Thank you for your contribution! 😍
Your change works - but also stops object type filter *ALL from working. Can you fix this?
janfh
had a problem deploying
to
testing_environment
GitHub Actions
Failure
janfh
had a problem deploying
to
testing_environment
GitHub Actions
Failure
janfh
had a problem deploying
to
testing_environment
GitHub Actions
Failure
chrjorgensen
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2269
Objectbrowser filter needs to check if object is a source file if filter contains both *SRCPF and other object types - not only the object type.