GYR1-616 Add Hub additional notes p5 + pertinent mappings #5431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heroku app: https://gyr-review-app-5431-da5cb9598458.herokuapp.com/ |
spompea-cfa
force-pushed
the
gyr1-616-hub-page-5-with-mappings
branch
from
a9b1001 to
68f1e35
Compare
spompea-cfa
changed the title
spompea-cfa
changed the title
spompea-cfa
changed the title
embarnard
approved these changes
Jan 27, 2025
| <div class="form_13614c slab slab--not-padded"> | ||
| <h1><%= @title %></h1> | ||
| <p>Last client 13614-C | ||
| update: <%= @client.last_13614c_update_at&.in_time_zone("America/Los_Angeles")&.strftime("%b %-d %l:%M %p") %></p> |
There was a problem hiding this comment.
Where is this timezone coming from?
There was a problem hiding this comment.
that's a good question. it's just what was in the preexisting ERBs in the editable 14-C flow. now that you mention it, i do wonder if it being hardcoded like that is the best idea. but afaik, that's the way it was for ty2023. could be worth following up on though.
| header = 'Additional Notes/Comments' | ||
| expect(page).to have_text header | ||
|
|
||
| note = 'It was very late and everyone had left the café except an old man who sat in the shadow the leaves of the tree made against the electric light.' |
spompea-cfa
force-pushed
the
gyr1-616-hub-page-5-with-mappings
branch
from
c0b9f0c to
5562879
Compare
|
@embarnard also, i meant to have the write-up ready before putting into review. i've added that now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Jira issue
Is PM acceptance required?
Reminder: merge main into this branch and get green tests before merging to main
What was done?
Notes/Comments" field. This field should "start out" with whatever comments
the client entered into the FinalInfoController screen back during the intake
flow.
the PDF.
5th page when there are 4 or more dependents.
Technical Notes
additional_notes_commentshas been created, which is atextcolumn, toreplace the legacy
final_infostringcolumn. I thinktextis thepreferable data type here.
additional_infowasn't really being used, so it's no longerincluded in the string that gets written out to the PDF.
How to test?
navigating to page 5 in the Hub
show up properly on the PDF.
properly on page 5 of the PDF.
the order of how values were written out on the PDF.
records.
Example