Merge pull request #1 from otacke/fix-question-type-contract

Fix question type contract when called on empty content
codefluegel · Nov 29, 2024 · 8576b37 · 8576b37
2 parents 4cebf32 + a03416b
commit 8576b37
Show file tree

Hide file tree

Showing 3 changed files with 80 additions and 59 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -28,9 +28,9 @@
     "eslint-config-snordian-h5p": "github:otacke/eslint-config-snordian-h5p",
     "mini-css-extract-plugin": "^2.9.2",
     "resolve-url-loader": "^5.0.0",
-    "sass": "^1.80.6",
+    "sass": "^1.81.0",
     "sass-loader": "^16.0.3",
-    "stylelint": "^16.10.0",
+    "stylelint": "^16.11.0",
     "stylelint-config-recommended": "^14.0.1",
     "stylelint-config-recommended-scss": "^14.1.0",
     "webpack": "^5.96.1",

diff --git a/src/scripts/components/content.js b/src/scripts/components/content.js
@@ -240,7 +240,7 @@ export default class Content {
    * @returns {boolean} True, if answer was given.
    */
   getAnswerGiven() {
-    const choices = this.questionScreen.getChoices();
+    const choices = this.questionScreen?.getChoices() ?? [];
 
     for (const panel of choices) {
       if (panel.options.some((option) => option.selected)) {
@@ -256,7 +256,7 @@ export default class Content {
    * @returns {number} Current position.
    */
   getCurrentPosition() {
-    return this.questionScreen.getCurrentPanelIndex();
+    return this.questionScreen?.getCurrentPanelIndex() ?? 0;
   }
 
   /**