⚡️ Speed up method MockRequest.is_unverifiable
by 5% in src/requests/cookies.py
#3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄
MockRequest.is_unverifiable()
insrc/requests/cookies.py
📈 Performance improved by
5%
(0.05x
faster)⏱️ Runtime went down from
50.5 microseconds
to47.9 microseconds
(best of88
runs)Explanation and details
Certainly! Here is an optimized version of your program.
Changes made.
urlparse
with a regex match using there
module for a more efficient extraction of the scheme.staticmethod
to define the_get_scheme
method for clarity and encapsulation of the scheme extraction logic.Correctness verification
The new optimized code was tested for correctness. The results are listed below.
🔘 (none found) − ⚙️ Existing Unit Tests
✅ 129 Passed − 🌀 Generated Regression Tests
(click to show generated tests)
🔘 (none found) − ⏪ Replay Tests