⚡️ Speed up method HTTPAdapter.request_url
by 13%
#25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 13% (0.13x) speedup for
HTTPAdapter.request_url
insrc/requests/adapters.py
⏱️ Runtime :
867 microseconds
→769 microseconds
(best of70
runs)📝 Explanation and details
Here is a rewritten and optimized version of the given Python program. The changes are highlighted in comments.
Key optimizations include.
urlparse(url)
by reusing the parsed URL components.proxy_keys
(iteration over anin
check automatically stops on first match).✅ Correctness verification report:
⚙️ Existing Unit Tests Details
🌀 Generated Regression Tests Details
📢 Feedback on this optimization?