⚡️ Speed up function select_proxy
by 22%
#23
+11
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 22% (0.22x) speedup for
select_proxy
insrc/requests/utils.py
⏱️ Runtime :
1.02 millisecond
→829 microseconds
(best of21
runs)📝 Explanation and details
Sure! Here is a more optimized version of the program.
Changes Made.
urlparse
fromurllib.parse
instead ofsrc.requests.compat
for a more standard approach.proxies
to itself with a default empty dictionary since we handle theif not proxies
check earlier.or
operator to check for each proxy key in a single statement, reducing overhead and making it faster.urlparts.hostname
intohostname
.These changes help in reducing the complexity of the function and should result in a better overall performance.
✅ Correctness verification report:
⚙️ Existing Unit Tests Details
🌀 Generated Regression Tests Details
📢 Feedback on this optimization?