⚡️ Speed up method AdAssetFeedSpecAssetCustomizationRule._get_field_enum_info
by 12% in facebook_business/adobjects/adassetfeedspecassetcustomizationrule.py
#14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄
AdAssetFeedSpecAssetCustomizationRule._get_field_enum_info()
infacebook_business/adobjects/adassetfeedspecassetcustomizationrule.py
📈 Performance improved by
12%
(0.12x
faster)⏱️ Runtime went down from
308 microseconds
to274 microseconds
(best of111
runs)Explanation and details
Certainly! The provided code is already quite simple, but I'll optimize it by removing redundancies and making it slightly more efficient without changing its functionality.
self._isAdAssetFeedSpecAssetCustomizationRule = True
line can be moved to a class variable to avoid setting it on every instance creation.api
parameter in the constructor can be set as a default value toNone
directly.Here's your optimized code.
The optimizations.
_isAdAssetFeedSpecAssetCustomizationRule
to a class level variable, set only once.field_enum_info
in_get_field_enum_info
function, directly returning an empty dictionary.Correctness verification
The new optimized code was tested for correctness. The results are listed below.
🔘 (none found) − ⚙️ Existing Unit Tests
✅ 1029 Passed − 🌀 Generated Regression Tests
(click to show generated tests)
🔘 (none found) − ⏪ Replay Tests