Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events Pagination fix #2259

Closed
wants to merge 1 commit into from
Closed

Events Pagination fix #2259

wants to merge 1 commit into from

Conversation

bernardhanna
Copy link
Collaborator

This pull request addresses an issue in Pagination.vue flagged by Paula, where pagination buttons were not functioning as expected. The original code used an outdated event emission method (this.$dispatch('paginate')), which has been updated to the correct Vue.js method (this.$emit('paginate', page)).

Changes Made:

  • Replaced this.$dispatch('paginate') with this.$emit('paginate', page) in the changePage method.
  • Enhanced changePage logic to handle edge cases where the page number is out of bounds.
  • Refactored the code for better readability and formatting.

Impact:

  • Pagination buttons now emit the correct events, enabling the parent component to handle page changes properly.
  • Improved user experience during pagination.

Testing:

  • Manually tested to confirm correct event emission and parent component response.
  • Verified that the pagination component renders and functions as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant