Add support for Swift #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Swift as a viable option using the changes I added to the language templates repo PR.
I tested locally by pointing course-sdk to my repo which included the new language.
I'm not an expert in swift-nio, but the provided script code succeeded when running
course-sdk test swift. With the recent changes I made to the language templates PR linked above, swift-nio gets built when the image is built and is available to use as a cache for the incremental build required to run the program. It took a total of 12 seconds to run the starter and solution scripts combined which you can see in the screenshot below.