Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advertise shared as being typed, and add vscode settings #357

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

Swatinem
Copy link
Contributor

The main addition here is the py.typed file, which advertises to mypy that this package indeed has type annotations, so downstream users like worker are properly using those.

As another change, this adds some vscode settings with recommended extensions, and sets up ruff to auto-fix/format on-save, which is copied from codecov/worker#706.

The main addition here is the `py.typed` file, which advertises to `mypy` that this package indeed has type annotations, so downstream users like `worker` are properly using those.

As another change, this adds some vscode settings with recommended extensions, and sets up ruff to auto-fix/format on-save.
@Swatinem Swatinem requested a review from a team September 13, 2024 10:43
@Swatinem Swatinem self-assigned this Sep 13, 2024
@Swatinem
Copy link
Contributor Author

It seems that I am also running into python/mypy#13392, as I can’t pip install --editable ../shared from worker unfortunately :-(

I am once again hitting the limit of my knowledge of the python ecosystem here.

@Swatinem Swatinem added this pull request to the merge queue Sep 17, 2024
Merged via the queue into main with commit 27586f9 Sep 17, 2024
6 checks passed
@Swatinem Swatinem deleted the swatinem/pytyped branch September 17, 2024 14:28
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.12%. Comparing base (d26f241) to head (cbae424).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #357      +/-   ##
==========================================
- Coverage   89.78%   89.12%   -0.66%     
==========================================
  Files         375      324      -51     
  Lines       11638     9712    -1926     
  Branches     2063     1737     -326     
==========================================
- Hits        10449     8656    -1793     
+ Misses       1101      992     -109     
+ Partials       88       64      -24     
Flag Coverage Δ
shared-docker-uploader ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants